Add WithRetryHandler for a custom RetryPolicy

[acouvreur]

Context:
My test is as simple as:

e.GET("/nginx").
		WithMaxRetries(10).
		WithRetryDelay(time.Second, time.Second*2).
		WithRetryPolicy(httpexpect.RetryAllErrors).
		Expect().
		Status(http.StatusNotFound).
		Body().Contains(`nginx/`)

I'm expecting a dynamic result from one call to the other. And I'd like to handle the retry policy myself here. Whuch does not seems doable right now.

So something like:

e.GET("/nginx").
		WithMaxRetries(10).
		WithRetryDelay(time.Second, time.Second*2).
		WithRetryPolicy(httpexpect.RetryAllErrors).
		WithRetryHandler(func(resp *http.Response, err error) bool {
			// Check body if available, etc.
			return ...
		})
		Expect().
		Status(http.StatusNotFound).
		Body().Contains(`nginx/`)

What do you think ?

[acouvreur]

So, I have no tests and all, but this is working for my use case:

acouvreur@4197623

[gavv]

Nice idea, pull requests are welcome!

"handler" is probably a bit misleading here, because it suggests that this function handles retry, but it instead decides whether to perform a retry.

Maybe something simpler like WithRetryFunc would fit better.

[nkzren]

So, I have no tests and all, but this is working for my use case:

acouvreur@4197623

@acouvreur I've included a simple test and some docs on top of your commit and @gavv 's suggestion to rename the function (with your co-author on the commit ofc, I hope you don't mind)

[acouvreur]

So, I have no tests and all, but this is working for my use case:

acouvreur@4197623

@acouvreur I've included a simple test and some docs on top of your commit and @gavv 's suggestion to rename the function (with your co-author on the commit ofc, I hope you don't mind)

Looks great! Thanks!

[rafiramadhana]

@gavv can I work on this?

the previous MR #429 is just closed

[gavv]

@rafiramadhana Sure, thanks. I agree with the comment about the test, but didn't have a chance to look at the PR closely yet.