Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on arm64 #3

Merged
merged 5 commits into from May 7, 2024
Merged

Fix build on arm64 #3

merged 5 commits into from May 7, 2024

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented May 3, 2024

Ogre currently needs SIMD_NEON SIMD_SSE2 turned off in order to build on arm64 architecture. These are also used in our upstream Ogre-next packages:

I've tested this locally with docker (with qemu) and it built successfully.

Upstream issue: OGRECave/ogre-next#430

azeey added 4 commits May 2, 2024 16:18
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from j-rivero May 3, 2024 16:26
CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvement to deal with other platforms. Good to go anyway.

Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@azeey azeey merged commit 7895959 into rolling May 7, 2024
@azeey azeey deleted the azeey/fix_arm64 branch May 7, 2024 17:47
azeey added a commit that referenced this pull request May 7, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants