New homebrew bottle #28
Comments
|
Original comment by Deanna Hood (Bitbucket: d_hood). Ah, I think if it includes https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-rendering/pull-requests/78/ we'll also need a new ignition-cmake bottle too, is that right? |
|
Original comment by Nate Koenig (Bitbucket: Nathan Koenig). ➤ Ian Chen commented: ya that commit should be good for making a new homebrew bottle |
|
Original comment by Nate Koenig (Bitbucket: Nathan Koenig). ➤ Ian Chen commented: ah yes, it depends on the recent changes in ign-cmake to find ogre so will need a new ign-cmake bottle |
|
Original comment by Deanna Hood (Bitbucket: d_hood). update is that we are looking for what needs to be changed so that os x works with the changes to how the ogre plugindir is found (https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/107 is an attempt but is still a work-in-progress). |
|
Original comment by Nate Koenig (Bitbucket: Nathan Koenig).
|
|
Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033). New bottle was built - related homebrew-simulation PR |
Original report (archived issue) by Deanna Hood (Bitbucket: d_hood).
I am looking to submit a PR to https://github.com/osrf/homebrew-simulation/ to make a new bottle for ignition-rendering0 for https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-gui/pull-requests/143
From a comment at https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-gui/pull-requests/143/remove-override-of-onvisibilitychange-for/diff#comment-71298175 I'm led to believe this is a straightforward thing to do, I just have to bump to a newer commit. If that's the case, is the current default tip (46f0b21) OK to use?
The text was updated successfully, but these errors were encountered: