Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metal] Fix per-point colors in point clouds to match #494 #550

Merged

Conversation

srmainwaring
Copy link
Contributor

🦟 Bug fix

Follow up to #494

Summary

This fix applies changes proposed by @iche033 to update Metal shaders that were missed from the merged PR.

It is a cherry-pick of 5df748e

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #550 (1b84d59) into main (0310d26) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1b84d59 differs from pull request most recent head 69c353e. Consider uploading reports for the commit 69c353e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   53.36%   53.37%           
=======================================
  Files         211      211           
  Lines       20830    20830           
=======================================
+ Hits        11116    11117    +1     
+ Misses       9714     9713    -1     
Impacted Files Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1559fe5...69c353e. Read the comment docs.

Core development automation moved this from Inbox to In review Jan 26, 2022
@iche033 iche033 merged commit 30f9a5e into gazebosim:main Jan 26, 2022
Core development automation moved this from In review to Done Jan 26, 2022
@srmainwaring srmainwaring deleted the pr/per-point-colors-in-point-clouds-metal branch January 26, 2022 21:50
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants