Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused point cloud color uniform variable #721

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 13, 2022

馃 Bug fix

Fixes #719

We're not longer using the color uniform in the shaders so removing it to prevent a warning from popping up in the ogre2.log on macOS

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 馃尡 garden Ignition Garden label Sep 13, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Sep 13, 2022
Core development automation moved this from Inbox to In review Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #721 (aed9158) into gz-rendering7 (ff5d75e) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           gz-rendering7     #721   +/-   ##
==============================================
  Coverage          74.14%   74.14%           
==============================================
  Files                164      164           
  Lines              14351    14351           
==============================================
  Hits               10641    10641           
  Misses              3710     3710           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit d44f6ef into gz-rendering7 Sep 14, 2022
Core development automation moved this from In review to Done Sep 14, 2022
@ahcorde ahcorde deleted the point_color_warning branch September 14, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃尡 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants