Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting emissive map #723

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Fix setting emissive map #723

merged 2 commits into from
Sep 14, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 13, 2022

馃 Bug fix

Summary

It was incorrectly setting the emissive map with the metalness map texture.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@osrf-triage osrf-triage added this to Inbox in Core development Sep 13, 2022
@github-actions github-actions bot added the 馃尡 garden Ignition Garden label Sep 13, 2022
@jennuine jennuine added the bug Something isn't working label Sep 13, 2022
Core development automation moved this from Inbox to In review Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #723 (e5d516d) into gz-rendering7 (5c9a665) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           gz-rendering7     #723   +/-   ##
==============================================
  Coverage          74.14%   74.14%           
==============================================
  Files                164      164           
  Lines              14351    14351           
==============================================
  Hits               10641    10641           
  Misses              3710     3710           
Impacted Files Coverage 螖
ogre2/src/Ogre2Material.cc 76.93% <100.00%> (酶)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit c8dddd6 into gz-rendering7 Sep 14, 2022
Core development automation moved this from In review to Done Sep 14, 2022
@ahcorde ahcorde deleted the fix_emissive_map branch September 14, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 馃尡 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants