Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve path expansion #19

Open
gazorby opened this issue Aug 15, 2022 · 0 comments
Open

Improve path expansion #19

gazorby opened this issue Aug 15, 2022 · 0 comments

Comments

@gazorby
Copy link
Owner

gazorby commented Aug 15, 2022

The current fix accounts for 99% use cases, but it doesn't completely fix the problem, for example ~root won't work.

See comment by @kidonng in #16 (comment)_

As per the docs, there are four cases where fish understands commandline as path without explicit use of cd:

cases file completion in fifc
1. starting with . ❌ display fish completions but doesn't trigger find/fd
2. starting with /
3. starting with ~ ~/* works but not ~*
4. ending with /

While 3 is a bug, 1 follows the same logic as other completion rules:

If not all item from fish completion output doesn't belong to any particuluar group (path, process ids, commands etc) we use fish completion instead of a custom command to feed fzf.

So when tabbing on .config fifc won't trigger find/fd completion as fish doesn't path-complete.

@gazorby gazorby changed the title This fix accounts for 99% use cases, but it doesn't completely fix the problem, for example ~root won't work. Improve path expansion Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant