Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Dispatcher Contract fire() method removal support #65

Closed
DanWithams7d opened this issue May 15, 2019 · 7 comments
Closed

Event Dispatcher Contract fire() method removal support #65

DanWithams7d opened this issue May 15, 2019 · 7 comments

Comments

@DanWithams7d
Copy link

In later version of laravel after 5.5 the EventDispatch contract was changed so that fire() is no longer the method for dispatching events. This was changed to dispatch()

We should support this throughout the package

@DanWithams7d
Copy link
Author

I've created a PR to fix this;

#64

@alalfakawma
Copy link

Please pull this @gazsp, really needed for Laravel 5.8

@Lunatig
Copy link

Lunatig commented Jun 25, 2019

@gazsp please

@gazsp
Copy link
Owner

gazsp commented Jun 25, 2019

Done

@alalfakawma
Copy link

@gazsp I see you've merged this to feature/2.0 and not the master branch, but I want to use this in production for a Laravel 5.8 app, is it now safe to use feature/2.0?

@appdezign
Copy link

@gazsp Please merge this to the master branch. I would also like to use this in production for a Laravel 5.8 app.

@poing
Copy link
Collaborator

poing commented Dec 17, 2020

Under New Management

Focusing support for later Laravel versions.

Cleaning up and closing some of the really old issues. Things that might still be a problem will be transferred to a consolidated issue.

@poing poing closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants