Binary key support + key trait #49
Conversation
src/keys/binary_key.rs
Outdated
| /// | start end | ||
| /// ``` | ||
| #[derive(Debug, PartialEq, Clone)] | ||
| pub struct BinaryKey(pub Vec<u8>, pub usize, pub usize); // (key data, offset in first byte, offset in last byte) |
There was a problem hiding this comment.
Suggestion: instead of exposing the underlying byte-based structure, let the calling code use general bit offsets. By that I mean the first bit from left has offset 0 and if the key length is 16, the last bit (rightmost) has offset 15. This feels more intuitive for me.
Although I can see when you repeatedly want to slice the key, then those offsets change.
|
So after considering the iterator route for some time, and in spite of being convinced that this is the best way in the long run, I also realized it was going to be fairly heavy work, and it's not currently necessary if it's just about not making a couple fields public. I will go ahead with this one in order to resume work on binary trees, and will fix that for the 2.x release. |
This is preparation work for the support of binary trees.
Keytrait that will have to be implemented by all objects that can be used as keys;BinaryKeythat implementsKeyand represents a bit-wise string;ByteKeyandNibbleKeyas an implementation ofKey; andByteKey,NibbleKeyandBinaryKeyto their own modules.