You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that relative.influence and summary give different answers for the relative influence for multinomial distributions and when I looked a bit deeper I noticed that relative.influence gives a different result if it is called with n.trees specified or the default which is to take the object$n.trees
The problem is that in relative.influence it multiplies n.trees by the number of classes but this multiplication is incorrectly located inside the if(missing(n.trees)) statement. Should be an easy fix but fairly important.
The text was updated successfully, but these errors were encountered:
@bgreenwell The pull request looks good to me, for what it's worth. I'm not imaginative enough to think of a use case in which you'd not want to perform that multiplication, so the pull request as written seems as reasonable to me as the alternative of keeping relative.influence as-is but multiplying within summary.gbm.
I noticed that
relative.influence
andsummary
give different answers for the relative influence for multinomial distributions and when I looked a bit deeper I noticed thatrelative.influence
gives a different result if it is called withn.trees
specified or the default which is to take theobject$n.trees
The problem is that in
relative.influence
it multipliesn.trees
by the number of classes but this multiplication is incorrectly located inside theif(missing(n.trees))
statement. Should be an easy fix but fairly important.The text was updated successfully, but these errors were encountered: