Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Difference between this and "regular" SVD #7

Closed
BradKML opened this issue Mar 30, 2021 · 3 comments
Closed

Documentation: Difference between this and "regular" SVD #7

BradKML opened this issue Mar 30, 2021 · 3 comments

Comments

@BradKML
Copy link

BradKML commented Mar 30, 2021

As Wikipedia had suggested, Funk et. al. is not using the regular form of SVD with three variable, but rather a modified form of NMF with two variables but faster convergence and speed.

With reference to the Funk:

With reference to SVD:

Would it be good to explain how the optimization differs from NMF?

@gbolmier
Copy link
Owner

Hi @BrandonKMLee, Thank you for taking the time to drop a comment 😃

So far the README.md is the only documentation of the project. I would prefer to keep it short, concise, and not go too far into the theoretical details. The important part of the optimization process is already covered and a software documentation isn't supposed to explain much about the mathematical part. Nevertheless, I think it makes sense to add references for people interested in more background; I'll clean up the README.md and add some in the next days 👍

@BradKML
Copy link
Author

BradKML commented Mar 30, 2021

I think I might have asked the same question in an SVD repo that is slightly more relevant. ZWMiller/svdRec#1

@gbolmier
Copy link
Owner

gbolmier commented Apr 8, 2021

Added a References section in README.md (cf. corresponding commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants