Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Improve the PWA by updating the manifest.json, etc. #73

Open
gbowne1 opened this issue Feb 25, 2024 · 0 comments
Open

[TODO] Improve the PWA by updating the manifest.json, etc. #73

gbowne1 opened this issue Feb 25, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Feb 25, 2024

Create React App (which will be migrating from once we have a fully functional Twitch Bot) ships with:

  • A default serviceWorker.js
  • registerServiceWorker.js
  • a default manifest.json
  • Google Analytics package and file, reportWebVitals (uses the web-vitals package).

This is for a SWA/PWA. Even though this is not a PWA/SWA, We should consider updating this for:

  1. good browser feature usage (the Application tab/panel in Firefox shows the manifest and serviceWorker(s) @ app running.
  2. good SEO?
  3. good results in Google Lighthouse/Google Pagespeed

Not sure what to use the serviceWorker for but it's there for usage.

My thought was also that we can use the service worker for caching assets, handling push notifications, and enabling offline functionality in the client. But this could be also done using the (ws) WebSocket or TCP connections to send and receive chat messages.

@gbowne1 gbowne1 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

1 participant