Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow navbar to stay fixed on page #339

Closed
wants to merge 2 commits into from
Closed

Allow navbar to stay fixed on page #339

wants to merge 2 commits into from

Conversation

Piernas
Copy link
Contributor

@Piernas Piernas commented Apr 14, 2016

Small addition to allow navbar to stay on screen when scrolling the
content of a page.

Small addition to allow navbar to stay on screen when scrolling the
content of a page.
@BrockleyJohn
Copy link
Contributor

Perhaps it would be better to reverse the logic so that if added to an existing store without uninstalling and reinstalling, the previous behaviour doesn't change
$navbar_fixed = (MODULE_CONTENT_NAVBAR_FIXED == 'Yes') ? ' navbar-fixed-top' : '';

@gburton
Copy link
Owner

gburton commented Apr 14, 2016

Thanks

Installer (SQL) change.
CSS change.

Please solve these and push.

@gburton
Copy link
Owner

gburton commented Apr 14, 2016

Please rework the submission so that shopowner can choose "top", "bottom", "default".
SQL Installer needs updating
CSS needs updating

@Piernas
Copy link
Contributor Author

Piernas commented Apr 14, 2016

Done!

@gburton
Copy link
Owner

gburton commented Apr 14, 2016

Thank you.

@skleiner
Copy link

@gburton @Piernas
Preliminary Testing via Uniserver in development mode on Chrome, Firefox and Edge. And Smartphone. All appears to be working OK

@Piernas Piernas changed the title Allow navbar to stay fixed on top od the page Allow navbar to stay fixed on top of the page Apr 15, 2016
@gburton gburton changed the title Allow navbar to stay fixed on top of the page Allow navbar to stay fixed on page Apr 16, 2016
@gburton
Copy link
Owner

gburton commented Apr 19, 2016

#347

Optimises the code a little bit..

@gburton gburton closed this Apr 19, 2016
@rubberfashion
Copy link

Hi,

For mode: on top

Example: create_account.php on mobile device

When you miss selecting radio button M / F and click on Continue

you will not see the option button M / F, because it is hide by the navbar. You have to scoll up so see it.

Better would be to implement a offset of the high of the navbar. But i do not know how to do.

Also in the Destop mode same issue

By the way ... is it possbile to implement a logo in the navbar? It doesn't look really nice.

Thank you :)

Mobile
screenshot_20170812-130939

Desktop
unbenannt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants