Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable hover for items in ConceptTree #198

Closed
stefandesu opened this issue Nov 14, 2018 · 0 comments
Closed

Re-enable hover for items in ConceptTree #198

stefandesu opened this issue Nov 14, 2018 · 0 comments
Labels
low priority maybe later
Milestone

Comments

@stefandesu
Copy link
Member

stefandesu commented Nov 14, 2018

To improve performance, commit 168b6bb disabled the "remote hover" effect for concepts in ConceptTree (meaning that if you hover a specific concept elsewhere, it will not be hovered in ConceptTree as well). The reason this caused performance issues was that when there was a large number of concepts in ConceptTree, each would refresh its "isHovered" computed property on every single change to the globally hovered concept.

To re-enable this effect, the feature could be activated only for concepts that are currently visible in ConceptTree. The check which concepts are actually visible might itself have performance issues, but it's worth a try. See the checkInView function on top of this file for an implementation that checks whether an element is currently visible. This would have to be used on every change in the scroll position.

@stefandesu stefandesu added the low priority maybe later label Nov 14, 2018
@stefandesu stefandesu added this to the 1.0.0 milestone Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority maybe later
Projects
None yet
Development

No branches or pull requests

2 participants