Performance: do not check for string in patter_parser (#56)

We can trust that the input is a string. Checking for this is expensive. The number of calls to is_str went down from 280000 calls to 22000 in most simple cases. The test is also no more needed. If somebody gives a wrong input, it will just fail with an exception.
CastXML · Jul 5, 2016 · 648e8da · 648e8da
1 parent 25bf2b2
commit 648e8da
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 69 deletions.
diff --git a/pygccxml/declarations/pattern_parser.py b/pygccxml/declarations/pattern_parser.py
@@ -28,7 +28,6 @@ def __init__(
 
     def has_pattern(self, decl_string):
         """implementation details"""
-        assert utils.is_str(decl_string)
         last_part = decl_string.split('::')[-1]
         return (
             -1 != decl_string.find(self.__begin) and -
@@ -37,7 +36,6 @@ def has_pattern(self, decl_string):
 
     def name(self, decl_string):
         """implementation details"""
-        assert utils.is_str(decl_string)
         if not self.has_pattern(decl_string):
             return decl_string
         args_begin = decl_string.find(self.__begin)

diff --git a/unittests/data/basic.hpp b/unittests/data/basic.hpp
diff --git a/unittests/from_future_import_tester.py b/unittests/from_future_import_tester.py
diff --git a/unittests/test_all.py b/unittests/test_all.py
@@ -62,7 +62,6 @@
 import gccxml10185_tester
 import inline_specifier_tester
 import test_create_decl_string
-import from_future_import_tester
 import pep8_tester
 import example_tester
 import test_utils
@@ -128,7 +127,6 @@
     gccxml10185_tester,
     inline_specifier_tester,
     test_create_decl_string,
-    from_future_import_tester,
     example_tester,
     test_utils,
     test_va_list_tag_removal,