Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MurmurHash3 Operation #1694

Merged
merged 5 commits into from Feb 8, 2024
Merged

Add MurmurHash3 Operation #1694

merged 5 commits into from Feb 8, 2024

Conversation

AliceGrey
Copy link
Contributor

Fixes #1375

@AliceGrey
Copy link
Contributor Author

This is useful for generating favicon hashes for threat hunting in Shodan
Recipe:

To_Base64('A-Za-z0-9+/=')
Find_/_Replace({'option':'Regex','string':'(.{76})'},'$1\\n',true,true,true,true)
Find_/_Replace({'option':'Regex','string':'$'},'\\n',true,false,false,false)
MurmurHash3(0)

a3957273
a3957273 requested changes Feb 3, 2024
View reviewed changes
src/core/operations/Murmurhash3.mjs Outdated Show resolved Hide resolved
src/core/operations/Murmurhash3.mjs Outdated Show resolved Hide resolved
@AliceGrey
Copy link
Contributor Author

Rebased

@AliceGrey
Copy link
Contributor Author

I believe I may have found a bug. Converting it back to a draft for now.

@AliceGrey AliceGrey marked this pull request as draft February 6, 2024 19:06
@AliceGrey
Fix calculation bug and add Convert to Signed
cfc8a50 
A signed output is often needed for Shodan and other favicon searches.
@AliceGrey AliceGrey marked this pull request as ready for review February 6, 2024 20:22
@AliceGrey
Copy link
Contributor Author

Should be g2g now

@a3957273
Copy link
Member

a3957273 commented Feb 8, 2024

Thanks for the contribution @AliceGrey, this looks really good. :)

@a3957273 a3957273 merged commit a3944fe into gchq:master Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a3957273 a3957273 Awaiting requested review from a3957273

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Support Murmur-Hash
2 participants
@AliceGrey @a3957273