Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Salsa20 and XSalsa20 operation #1750

Merged
merged 1 commit into from Mar 29, 2024

Conversation

joostrijneveld
Copy link
Contributor

@joostrijneveld joostrijneveld commented Mar 10, 2024

As a continuation of #1466 and #1606, this adds the Salsa20 and XSalsa20 stream ciphers, as well as parameters to support their round-reduced variants (Salsa20/8, Salsa20/12, XSalsa20/8, XSalsa20/12).

This relates to #1603 as well.

@a3957273
Copy link
Member

Just tried it out and this seems like a fantastic implementation.

Whilst I'm not sure on some of the decisions here (e.g. including 'output format', when the 'to hex' operation exists), it does match the rest of the crypt operations that are implemented within CyberChef.

Thanks for the contribution ❤️ .

@a3957273 a3957273 merged commit 0f14d23 into gchq:master Mar 29, 2024
4 checks passed
@joostrijneveld
Copy link
Contributor Author

joostrijneveld commented Mar 29, 2024

Thanks for merging!

Whilst I'm not sure on some of the decisions here (e.g. including 'output format', when the 'to hex' operation exists), it does match the rest of the crypt operations that are implemented within CyberChef.

@a3957273 I completely agree; the same goes for input formats to some extent, I suppose. While I was somewhat reluctant, I figured I'd try to be consistent with the existing modules. There's definitely something to be said for small, atomic operations. Should we create a separate issue to clean up output formats across the various (crypt) recipes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants