Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kind version to ensure tests pass #253

Closed
t92549 opened this issue Sep 8, 2022 · 2 comments · Fixed by #254
Closed

Fix kind version to ensure tests pass #253

t92549 opened this issue Sep 8, 2022 · 2 comments · Fixed by #254
Assignees
@t92549
Labels
automation GitHub Actions, CI/CD
Milestone
v2.0.0-alpha-0.3

Comments

@t92549
Copy link
Contributor

t92549 commented Sep 8, 2022

The GitHub actions runner has changed version of kind to 0.15.0 from 0.14.0, which now by default uses kubernetes v1.25.0.
Because of the PodDisruptionBudget deprecations, the zookeeper chart is breaking in tests.

As this chart is out of our control, we should fix the CI's usages of kind to use kubernetes v1.24.0
@t92549 t92549 added the automation GitHub Actions, CI/CD label Sep 8, 2022
@t92549 t92549 added this to the v2.0.0-alpha-0.3 milestone Sep 8, 2022
@t92549 t92549 self-assigned this Sep 8, 2022
@t92549
Copy link
Contributor Author

t92549 commented Sep 8, 2022

A longer term fix that would need more testing would be to instead update the zookeeper dependency to use a helm chart this is not deprecated, for example to this bitnami chart.

@github-actions github-actions bot mentioned this issue Sep 8, 2022
Merged
@t92549 t92549 linked a pull request Sep 9, 2022 that will close this issue
Set kubernetes version to 1.24.4 in kind CI #254
Merged
@t92549
Copy link
Contributor Author

t92549 commented Sep 9, 2022

Fixed by #254

@t92549 t92549 closed this as completed Sep 9, 2022
This was referenced Sep 9, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t92549 t92549

Labels
automation GitHub Actions, CI/CD
Projects
None yet
Milestone
v2.0.0-alpha-0.3
Development

Successfully merging a pull request may close this issue.

Set kubernetes version to 1.24.4 in kind CI gchq/gaffer-docker
1 participant
@t92549