Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify security group to use for running ECS tasks #2805

Open
gaffer01 opened this issue Jul 3, 2024 · 0 comments · May be fixed by #2830
Open

Add ability to specify security group to use for running ECS tasks #2805

gaffer01 opened this issue Jul 3, 2024 · 0 comments · May be fixed by #2830
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gaffer01
Copy link
Member

gaffer01 commented Jul 3, 2024

Background

Some accounts are set up such that ECS tasks need to run with a security group in order to access ECR to obtain the images. Currently there is no way for the user to specify the security group to use to run the task.

Description

We'd like the user to be able to specify the security group to be used when any ECS tasks are run in the system.

Analysis

We can add an instance property for the security group. This can be applied to all the AwsVpcConfiguration objects in the code (RunCompactionTasks, RunIngestTasks, RunWriteRandomDataTaskOnECS). As the withSecurityGroups method on AwsVpcConfiguration takes multiple security groups, we can make the property a comma-separated list of security groups to be added.

@gaffer01 gaffer01 added the enhancement New feature or request label Jul 3, 2024
@gaffer01 gaffer01 added this to the 0.24.0 milestone Jul 3, 2024
@kr565370 kr565370 linked a pull request Jul 5, 2024 that will close this issue
4 tasks
@kr565370 kr565370 self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants