Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref load staging db serialises typeId as an int not a byte #4318

Open
at055612 opened this issue Jun 13, 2024 · 0 comments
Open

Ref load staging db serialises typeId as an int not a byte #4318

at055612 opened this issue Jun 13, 2024 · 0 comments
Labels
enhancement A new feature or enhancement to an existing feature f:ref data Issues relating to reference data loads or lookups
Milestone

Comments

@at055612
Copy link
Member

at055612 commented Jun 13, 2024

It should serialise the typeId as a byte to save on 3 bytes per value. This ought to make the staging db smaller and the load fractionally faster.

see stroom.pipeline.refdata.store.StagingValue

The staging envs are transient so there is no issue in changing the serialisation here.

@at055612 at055612 added enhancement A new feature or enhancement to an existing feature f:ref data Issues relating to reference data loads or lookups labels Jun 13, 2024
@at055612 at055612 added this to the v7.5 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or enhancement to an existing feature f:ref data Issues relating to reference data loads or lookups
Projects
None yet
Development

No branches or pull requests

1 participant