Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated "Add or Modify Sensors" #147

Closed
wants to merge 3 commits into from
Closed

Updated "Add or Modify Sensors" #147

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2020 •
edited by ghost

  1. Updated views/sensor.py to refelct new database schema
  2. Modified appearance and functioning of sensor.html page and associated javascript (sensor.js)
    2a) Included deleted row from add sensor view
  3. The CSS sheet was modified to some extent to include new styling for the update sensor.html
  4. In general, refactored code to shorten files and simplify variable names

1) Updated views/sensor.py to refelct new database schema
364bc7c 
2) Modified appearance and functioning of sensor.html page and associated javascript (sensor.js)
	2a) Included deleted row from add sensor view
@ghost ghost requested review from daisycrego and dandipietrantonio March 18, 2020 23:59
@ghost
Copy link
Author

ghost commented Mar 19, 2020

Made a change

@ghost ghost closed this Mar 19, 2020
daisycrego
daisycrego reviewed Mar 19, 2020
View reviewed changes
Copy link
Contributor

@daisycrego daisycrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandipietrantonio dandipietrantonio Awaiting requested review from dandipietrantonio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@daisycrego