Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix to make datasource work: set the datasource name for all pa… #338

Merged
merged 2 commits into from Apr 9, 2020
Merged

Quick fix to make datasource work: set the datasource name for all pa… #338

merged 2 commits into from Apr 9, 2020

Conversation

daisycrego
Copy link
Contributor

…nels to 'Datasource'

sunnybansal
sunnybansal approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@sunnybansal sunnybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@daisycrego daisycrego merged commit 7fdc0ca into frontend-team Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnybansal sunnybansal sunnybansal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daisycrego @sunnybansal