Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Remove excess print statements #372

Merged
merged 3 commits into from Apr 11, 2020
Merged

Bug - Remove excess print statements #372

merged 3 commits into from Apr 11, 2020

Conversation

ab7289
Copy link
Contributor

@ab7289 ab7289 commented Apr 11, 2020

This PR comments out print statements that were clogging up the test logs or converts them to logger statements.

@ab7289 ab7289 added the hardware hardware-related work label Apr 11, 2020
yashasvid
yashasvid approved these changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@yashasvid yashasvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ab7289 ab7289 merged commit 7691410 into hardware-team Apr 11, 2020
@ab7289 ab7289 deleted the bug/print-logs branch April 11, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashasvid yashasvid yashasvid approved these changes

@PrabhanshuAttri PrabhanshuAttri Awaiting requested review from PrabhanshuAttri

@MichaelLally MichaelLally Awaiting requested review from MichaelLally

Assignees
No one assigned
Labels
hardware hardware-related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ab7289 @yashasvid