Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate forumla pipeline #477

Merged
merged 9 commits into from Apr 20, 2020
Merged

Integrate forumla pipeline #477

merged 9 commits into from Apr 20, 2020

Conversation

alldne
Copy link
Contributor

@alldne alldne commented Apr 19, 2020 •
edited

What it does:

  • Make measurement API to use formula pipeline
  • Delete unused files (serializer.py and associated tests)
  • Ensure 100% of test coverage for the measurement.py

@alldne alldne force-pushed the backend/use-formula branch 3 times, most recently from bc3f57c to 46ad343 Compare April 20, 2020 14:55
@alldne alldne marked this pull request as ready for review April 20, 2020 14:55
@alldne alldne marked this pull request as draft April 20, 2020 15:00
@alldne alldne marked this pull request as ready for review April 20, 2020 19:40
@alldne alldne marked this pull request as draft April 20, 2020 19:40
@alldne alldne marked this pull request as ready for review April 20, 2020 21:23
jackxujh
jackxujh approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@jackxujh jackxujh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, particularly plausible:

  • the usage of fixtures in tests
  • more concise and self-explanatory code

@jackxujh jackxujh merged commit c2f179b into backend-team Apr 20, 2020
@jackxujh jackxujh mentioned this pull request Apr 20, 2020
Merged
@jackxujh jackxujh deleted the backend/use-formula branch April 20, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackxujh jackxujh jackxujh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alldne @jackxujh @iamvibhorsingh