Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SensePi Tests #567

Merged
merged 7 commits into from Apr 27, 2020
Merged

SensePi Tests #567

merged 7 commits into from Apr 27, 2020

Conversation

ab7289
Copy link
Contributor

@ab7289 ab7289 commented Apr 26, 2020

Title

This PR adds test coverage for the sensePi package.

Description

This PR does not add any new features or bugfixes. Just adds test coverage.

Types of Changes

Put an x in the boxes that apply

  • [ x] Feature (non-breaking change which adds functionality)
  • Bug Fix (non-breaking change that fixes an issue)
  • Breaking Change (feature/fix that causes existing features to not work as expected)
  • Documentation

Checklist

  • [ x] I have read the [contribute]contributing doc
  • [ x] Classes, scripts, and environment variables follow existing naming convention
  • [ x] Lint and Unit tests pass locally
  • [ x] New features on hardware have been tested on a local Raspberry Pi
  • [ x] Mention new programs/binaries if any must be installed along with this change
  • [ x] Mention new environment variables if any have been added to hardware/env file
  • [ x] Test coverage should not drop more than 3%

@ab7289 ab7289 added the hardware hardware-related work label Apr 26, 2020
Copy link
Contributor

@yashasvid yashasvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ab7289 ab7289 merged commit a500aae into hardware-team Apr 27, 2020
@ab7289 ab7289 deleted the tests/sensepi branch April 28, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardware hardware-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants