Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published on the Snap Store #34

Closed
mharjac opened this issue May 4, 2019 · 13 comments
Closed

Published on the Snap Store #34

mharjac opened this issue May 4, 2019 · 13 comments
Labels
package Close once package has been added to manager

Comments

@mharjac
Copy link

mharjac commented May 4, 2019

I've published termshark on the Snap store so it can be easily installed on almost all major distros just by issuing: snap install termshark
After installation, it requires some additional permissions:

snap connect termshark:network-control
snap connect termshark:bluetooth-control
snap connect termshark:firewall-control
snap connect termshark:ppp
snap connect termshark:raw-usb
snap connect termshark:removable-media
@pocc
Copy link
Collaborator

pocc commented May 4, 2019

Cheers @mharjac! Thanks for your work on this.

@gcla
Copy link
Owner

gcla commented May 5, 2019

I'm new to snap and just tried it out - thanks @mharjac :-)

Just to be sure - I think it's the case that snap doesn't yet support filesystem capabilities, is that your understanding too? i.e. I was able to run the snap termshark like this

$ sudo termshark -i eth0

but not as an unprivileged user. Turned up this link by googling: https://forum.snapcraft.io/t/wireshark-and-setcap/9629

I'm on Ubuntu 18.10 at the moment.

One other very minor thing, and this is my fault - when it runs, it displays v<localbuild> at the top. I should've built the version in from the beginning :-/ If it's an easy thing to rebuild, you can get the current version in by compiling like this

$ go install -ldflags="-X github.com/gcla/termshark.Version=1.0.0" ./... 

But not a big deal! Thanks for the work.

@gcla
Copy link
Owner

gcla commented May 5, 2019

oh, I'll update the README, can I add your name to it?

@mharjac
Copy link
Author

mharjac commented May 6, 2019

Just to be sure - I think it's the case that snap doesn't yet support filesystem capabilities, is that your understanding too?

Yes, you're right. Currently it isn't possible to execute it without root privileges.

One other very minor thing, and this is my fault - when it runs, it displays v<localbuild> at the top. I should've built the version in from the beginning :-/ If it's an easy thing to rebuild, you can get the current version in by compiling like this

Don't worry about that, it's just minor visual defect :) I've removed source-tag option from snapcraft.yaml, so from now on your every commit should trigger automatic rebuild and publish it to the edge channel and I would manually promote every stable release to the stable channel.

@mharjac
Copy link
Author

mharjac commented May 6, 2019

oh, I'll update the README, can I add your name to it?

Yeah, you have my permission :)

@tkisason
Copy link

tkisason commented May 7, 2019

awesome! 👍

@pocc pocc added the package Close once package has been added to manager label May 9, 2019
@gcla gcla closed this as completed Jun 7, 2019
@gcla gcla reopened this Nov 12, 2019
@gcla
Copy link
Owner

gcla commented Nov 12, 2019

Hi @mharjac - would it be possible for you to update the snap package to v2.0.2? Many thanks!

@mharjac
Copy link
Author

mharjac commented Nov 14, 2019

Hi @mharjac - would it be possible for you to update the snap package to v2.0.2? Many thanks!

Hey! I've tried to build new snap but it failed with the following errors while building app:

github.com/gcla/tail/tail.go:188:45: cannot use &tail.Tomb (type *"github.com/gcla/tail/vendor/gopkg.in/tomb.v1".Tomb) as type *"github.com/hpcloud/tail/vendor/gopkg.in/tomb.v1".Tomb in argument to tail.watcher.BlockUntilExists

github.com/gcla/tail/tail.go:327:49: cannot use &tail.Tomb (type *"github.com/gcla/tail/vendor/gopkg.in/tomb.v1".Tomb) as type *"github.com/hpcloud/tail/vendor/gopkg.in/tomb.v1".Tomb in argument to tail.watcher.ChangeEvents

@gcla
Copy link
Owner

gcla commented Nov 14, 2019

I think I've messed up the tags... Could you try the following:

export GO111MODULE=on
go install github.com/gcla/termshark/v2/cmd/termshark

Then try ~/go/bin/termshark -v ?

Thanks :)

@pocc pocc mentioned this issue Nov 15, 2019
@gcla
Copy link
Owner

gcla commented Nov 17, 2019

Sorry to pester you @mharjac - any luck with the snap? A couple of redditors were trying to install that way.

@mharjac
Copy link
Author

mharjac commented Nov 18, 2019

Unfortunately, not. As it seems, snapcraft's go plugin doesn't support go modules so I'm trying to override that.

@mharjac
Copy link
Author

mharjac commented Nov 18, 2019

Finally... 2.0.2 released in stable channel.

@gcla
Copy link
Owner

gcla commented Nov 19, 2019

Many thanks @mharjac!

@gcla gcla closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package Close once package has been added to manager
Projects
None yet
Development

No branches or pull requests

4 participants