Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make install" does not install desktop file nor icons #192

Closed
probonopd opened this issue Aug 1, 2017 · 4 comments
Closed

"make install" does not install desktop file nor icons #192

probonopd opened this issue Aug 1, 2017 · 4 comments

Comments

@probonopd
Copy link

probonopd commented Aug 1, 2017

make install does not install the desktop file in /usr/share/applications/ nor the icons in /usr/share/icons/....

Build log:
https://travis-ci.org/probonopd/GCompris-qt/builds/259858983#L2346-L2498

@petitlapin
Copy link
Member

Hi,

I did a fix in https://cgit.kde.org/gcompris.git/commit/?id=4ffffaf04ee775bf175bb451cd4796c4d949766b
If you install from git, you need to have ECM with version at least 1.6.0 to have the icon and desktop file installed. Can you check if you have this version (I added a log during the configuration phase)?

Johnny

@probonopd
Copy link
Author

Thanks @petitlapin. As I am building on Travis CI on Ubuntu 14.04, it seems like extra-cmake-modules is not available there. Why is it needed to just do a simple "copy" operation that I can do in two lines in bash? Sure I could compile it myself, but wouldn't that be overkill? https://askubuntu.com/a/859867

@petitlapin
Copy link
Member

petitlapin commented Aug 2, 2017

The ECM provides a portable way to get the different folder where to put the files. I guess we can do without it (no need to lose time to handle the compilation and potential issues) and add the copy in the script and once the CI will have the ECM we can remove the manual copy?

@probonopd
Copy link
Author

I am copying in the 2 files manually for now. Less hassle than ECM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants