Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watercycle broken starting after 2.1 #279

Closed
kentavv opened this issue Mar 19, 2022 · 5 comments
Closed

Watercycle broken starting after 2.1 #279

kentavv opened this issue Mar 19, 2022 · 5 comments

Comments

@kentavv
Copy link
Contributor

kentavv commented Mar 19, 2022

On a 1920x1080 landscape screen, Watercycle is broken in 2.3 and 2.2, sometime after 2.1. No amount of clicking will cause the clouds to rain. The screen is split in half between game and text. Thought problem had something to do with isVertical or textOnSide, but have not found a solution.

@petitlapin
Copy link
Member

@Animtim you did some updates on it, can you take a look?

@Animtim
Copy link
Member

Animtim commented Mar 19, 2022

Can you tell me on which operating system you have this issue, and how did you install gcompris (from which source) ?
Here it works.

That the screen is split in half image/half text is expected (as the image was redone in a square ratio to work on any screen ratio without distortion). Also the click on the cloud is activated only after it finishes moving above the mountains.

@Animtim
Copy link
Member

Animtim commented Mar 19, 2022

Ah, I can reproduce when building with Qt 5.15 (as I use 5.12 for main development and for the packages, I didn't notice it before). I'll take a look to fix it.

@Animtim
Copy link
Member

Animtim commented Mar 19, 2022

Ouch, I found that this issue is caused by a critical bug in Qt 5.15, reported almost 2 years ago and still not fixed :(
https://bugreports.qt.io/browse/QTBUG-85935

I'll make a workaround, hoping it gets fixed at some point. And then I'll have to double check all the other places where we use transitions...

@Animtim
Copy link
Member

Animtim commented Mar 19, 2022

Fixed. Thanks for the report!

@Animtim Animtim closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants