When invoked with --calls, show call coverage #666

odkq · 2022-08-31T18:34:33Z

Show them in summary writer. Total number of function calls and number
of calls executed.

HTML view: Show number of calls for each source file and the number of
them executed.

HTML view: In the source view, show the number of calls and executed calls for each
line in their own column.

Show them in summary writer. Total number of function calls and number of calls executed. HTML view: Show number of calls for each source file and the number of them executed. HTML view: In the source view, show the number of calls and executed calls for each line in their own column.

Spacetown

Some minor changes needed. Please add also test data for this as described in the documentation.

gcovr/coverage.py

gcovr/templates/root_page.html

gcovr/coverage.py

gcovr/templates/root_page.html

gcovr/templates/source_page.html

odkq · 2022-08-31T20:48:56Z

Added a test case at tests/calls with a reference output for gcc 11 at 3640cd5

Spacetown · 2022-09-01T07:52:22Z

Reference is needed for all compilers. After the pipeline there will be an artifact for every compiler. If you have Docker installed you can create also the reference data locally.

Spacetown · 2022-09-01T07:54:34Z

Please update the changelog and the authors.

Spacetown · 2022-09-01T12:52:05Z

Whole HTML reference needs to be updated. I'm currently not able to do this. Do you have Docker installed on your computer?

odkq · 2022-09-01T15:50:40Z

Whole HTML reference needs to be updated. I'm currently not able to do this. Do you have Docker installed on your computer?

I do, but when I run python3 -m nox --session 'docker_qa_compiler(all)' -- --update_reference I get
nox > Ran multiple sessions:
nox > * docker_qa_compiler(all): success
nox > * docker_qa_compiler(gcc-5): success
nox > * docker_qa_compiler(gcc-6): success
nox > * docker_qa_compiler(gcc-8): success
nox > * docker_qa_compiler(gcc-9): success
nox > * docker_qa_compiler(gcc-10): success
nox > * docker_qa_compiler(gcc-11): success
nox > * docker_qa_compiler(clang-10): success
nox > * docker_qa_compiler(clang-13): success
nox > * docker_qa_build_compiler(gcc-5): success
nox > * docker_qa_run_compiler(gcc-5): failed
nox > * docker_qa_build_compiler(gcc-6): success
nox > * docker_qa_run_compiler(gcc-6): failed
nox > * docker_qa_build_compiler(gcc-8): success
nox > * docker_qa_run_compiler(gcc-8): failed
nox > * docker_qa_build_compiler(gcc-9): success
nox > * docker_qa_run_compiler(gcc-9): failed
nox > * docker_qa_build_compiler(gcc-10): success
nox > * docker_qa_run_compiler(gcc-10): failed
nox > * docker_qa_build_compiler(gcc-11): success
nox > * docker_qa_run_compiler(gcc-11): failed
nox > * docker_qa_build_compiler(clang-10): success
nox > * docker_qa_run_compiler(clang-10): failed
nox > * docker_qa_build_compiler(clang-13): success
nox > * docker_qa_run_compiler(clang-13): failed

Somehow it is failing before (?) getting the new references?

Spacetown · 2022-09-01T19:43:28Z

The error messages should be above the summary of nox If you run python3 -m nox --session 'docker_qa_compiler(gcc-5)' -- --update_reference you get the error faster.

odkq · 2022-09-05T16:01:44Z

It looks like a problem in nox/docker in my setup:
nox > docker run --rm -e CC -e NOX_POSARGS -e NOX_OPTIONS -v /home/user/gcovr:/gcovr gcovr-qa-ubuntu_18.04-gcc-5-uid_1000
Running chmod with sudo...chown: cannot read directory '/gcovr/gcovr': Permission denied

I've tried in a Fedora 36 vm installing everything from scratch (python-nox, docker) and it also happens.

What is the recommended environment/distribution to run docker to retrieve the reference files?

Spacetown · 2022-09-05T16:10:17Z

It looks like a problem in nox/docker in my setup: nox > docker run --rm -e CC -e NOX_POSARGS -e NOX_OPTIONS -v /home/user/gcovr:/gcovr gcovr-qa-ubuntu_18.04-gcc-5-uid_1000 Running chmod with sudo...chown: cannot read directory '/gcovr/gcovr': Permission denied

I've tried in a Fedora 36 vm installing everything from scratch (python-nox, docker) and it also happens.

What is the recommended environment/distribution to run docker to retrieve the reference files?

I've only used it on MacOs. Can you try to modify the noxfile.py to use /home/user/gcovr:/gcovr:rw instead of /home/user/gcovr:/gcovr?

odkq · 2022-09-05T19:30:03Z

Copied the changed reference files for all tests from a succesful run in Ubuntu 18.04 vm

codecov · 2022-09-07T17:33:49Z

Codecov Report

Base: 95.24% // Head: 95.28% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (c316796) compared to base (398aaff).
Patch coverage: 98.64% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   95.24%   95.28%   +0.03%     
==========================================
  Files          24       24              
  Lines        3409     3479      +70     
  Branches      642      657      +15     
==========================================
+ Hits         3247     3315      +68     
- Misses         91       92       +1     
- Partials       71       72       +1

Flag	Coverage Δ
ubuntu-18.04	`94.01% <98.64%> (+0.06%)`	⬆️
windows-2019	`94.93% <98.63%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
gcovr/configuration.py	`99.36% <ø> (ø)`
gcovr/tests/test_args.py	`98.86% <ø> (ø)`
gcovr/gcov_parser.py	`98.98% <90.00%> (-0.50%)`	⬇️
gcovr/coverage.py	`99.06% <100.00%> (+0.10%)`	⬆️
gcovr/gcov.py	`75.96% <100.00%> (+0.18%)`	⬆️
gcovr/merging.py	`84.21% <100.00%> (+1.25%)`	⬆️
gcovr/writer/html.py	`95.29% <100.00%> (+0.30%)`	⬆️
gcovr/writer/json.py	`97.01% <100.00%> (+0.26%)`	⬆️
gcovr/writer/summary.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Spacetown · 2022-09-07T18:48:17Z

Copied the changed reference files for all tests from a succesful run in Ubuntu 18.04 vm

Shall I update the reference for you?

gcovr/configuration.py

Spacetown

LGFM.
Only some minor annotations. If everything is done the test data needs to be updated.

@latk I leave it up to you which PR is merged first, this one or your refactoring of the parser..

gcovr/writer/json.py

Updated json version to 0.4 as a new key was added (gcovr/calls)

gcovr/merging.py

Spacetown

LGFM. Thank you for working on this.

odkq · 2022-10-03T09:54:31Z

LGFM. Thank you for working on this.

Thank you for the great support and codebase!

Spacetown requested changes Aug 31, 2022

View reviewed changes

gcovr/coverage.py Outdated Show resolved Hide resolved

gcovr/templates/root_page.html Show resolved Hide resolved

gcovr/coverage.py Show resolved Hide resolved

gcovr/templates/root_page.html Show resolved Hide resolved

gcovr/templates/source_page.html Outdated Show resolved Hide resolved

odkq marked this pull request as draft August 31, 2022 19:36

pablmart added 5 commits August 31, 2022 21:56

Fix CallCoverage class documentation

6686c6c

Extra colgroups for decisions and calls if enabled.

fae82e7

Fix {%if indentations

4b1a45c

Use separate styles and variables for call coverage

7d45c6f

Added a test for call coverage

3640cd5

odkq marked this pull request as ready for review August 31, 2022 20:49

State that calls coverage only is for HTML (not json yet)

b5155a2

odkq requested a review from Spacetown August 31, 2022 21:00

Spacetown added Type: Enhancement Format: HTML labels Sep 1, 2022

Spacetown added this to the Upcoming release milestone Sep 1, 2022

pablmart added 4 commits September 1, 2022 13:00

Fix PEP-8 formatting errors

c805992

Update CHANGELOG and AUTHORS

b5ea922

Fix misplaced item in ChangeLog

a3c57b6

Fix more formatting errors

f5d08f6

pablmart added 2 commits September 1, 2022 16:11

Remove white line that made many expected html output to fail

f4d8a7f

Updated example_html.details.css

fa7490c

Updated test references retrieved from Ubuntu 18.04 vm

717c054

Spacetown added 3 commits September 7, 2022 22:44

Extend test with logical expression.

c611c87

Generate reference data.

e04dbb1

Fix test failure.

d3ee569

Spacetown reviewed Sep 7, 2022

View reviewed changes

gcovr/configuration.py Show resolved Hide resolved

pablmart added 3 commits September 14, 2022 18:00

Insert call coverage (optionally) in json output

f49826d

Merge branch 'master' of github.com:odkq/gcovr

37881e3

Support for merging call coverage from json reports

61aa9b1

Spacetown requested changes Sep 17, 2022

View reviewed changes

gcovr/writer/json.py Show resolved Hide resolved

gcovr/writer/json.py Outdated Show resolved Hide resolved

Preserve call number when writing the json file

e6194ec

Updated json version to 0.4 as a new key was added (gcovr/calls)

Spacetown requested changes Sep 20, 2022

View reviewed changes

gcovr/merging.py Outdated Show resolved Hide resolved

pablmart and others added 5 commits September 22, 2022 16:37

assert that callno's are the same on call cov merging

1b0f9e7

Fix PEP-8 issues

2d76487

Fix PEP-8 issues

a733f02

Fix test and update reference.

6ab7cd4

Fix some version identifiers in JSON test data.

c316796

Spacetown approved these changes Sep 28, 2022

View reviewed changes

Spacetown merged commit b5103e1 into gcovr:master Sep 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When invoked with --calls, show call coverage #666

When invoked with --calls, show call coverage #666

odkq commented Aug 31, 2022

Spacetown left a comment

odkq commented Aug 31, 2022

Spacetown commented Sep 1, 2022

Spacetown commented Sep 1, 2022

Spacetown commented Sep 1, 2022

odkq commented Sep 1, 2022

Spacetown commented Sep 1, 2022 •

edited

odkq commented Sep 5, 2022

Spacetown commented Sep 5, 2022

odkq commented Sep 5, 2022 •

edited

codecov bot commented Sep 7, 2022 •

edited

Spacetown commented Sep 7, 2022

Spacetown left a comment

Spacetown left a comment •

edited

odkq commented Oct 3, 2022

When invoked with --calls, show call coverage #666

When invoked with --calls, show call coverage #666

Conversation

odkq commented Aug 31, 2022

Spacetown left a comment

Choose a reason for hiding this comment

odkq commented Aug 31, 2022

Spacetown commented Sep 1, 2022

Spacetown commented Sep 1, 2022

Spacetown commented Sep 1, 2022

odkq commented Sep 1, 2022

Spacetown commented Sep 1, 2022 • edited

odkq commented Sep 5, 2022

Spacetown commented Sep 5, 2022

odkq commented Sep 5, 2022 • edited

codecov bot commented Sep 7, 2022 • edited

Codecov Report

Spacetown commented Sep 7, 2022

Spacetown left a comment

Choose a reason for hiding this comment

Spacetown left a comment • edited

Choose a reason for hiding this comment

odkq commented Oct 3, 2022

Spacetown commented Sep 1, 2022 •

edited

odkq commented Sep 5, 2022 •

edited

codecov bot commented Sep 7, 2022 •

edited

Spacetown left a comment •

edited