New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect compiler version from gcc output if not specified. #686
Conversation
Codecov ReportBase: 95.22% // Head: 95.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 24 24
Lines 3495 3498 +3
Branches 615 615
=======================================
+ Hits 3328 3331 +3
- Misses 94 95 +1
+ Partials 73 72 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! A couple of minor comments though.
Do the changes to the compiler selection interact with the set_environment() function?
FYI, the Github Actions logs are full of deprecation warnings, we should eventually address those. This is actually partially related to the GCC version problem since the Actions rely on some really ancient Ubuntu versions in order to install some compilers.
Co-authored-by: Lukas Atkinson <opensource@LukasAtkinson.de>
cc91a26
to
1e0a371
Compare
The following warnigng is not resolvable yet since PR seanmiddleditch/gha-setup-ninja#15 is still open.
|
8018369
to
f5cc5d6
Compare
@latk Most warnings are fixed but the following warning I don't understand:
We don't use echo "VARIABLE=MyValue" >> $GITHUB_ENV But we use a different quoting since a long time: echo VARIABLE="MyValue" >> $GITHUB_ENV With the quoting from the documentation it doesn't work. The environment isn't set. |
Since gcovr#686 the command `python3 -m nox -s 'docker_qa_compiler(all)' --reuse-existing-virtualenvs -- --update_reference` is working from newest to oldest version of compiler. Now the reuse of the test data doesn't work anymore. Only the detection of the compiler shall use the newest one, all other commands shall start with oldest version first.
* Fix update of reference for all compilers: Since #686 the command `python3 -m nox -s 'docker_qa_compiler(all)' --reuse-existing-virtualenvs -- --update_reference` is working from newest to oldest version of compiler. Now the reuse of the test data doesn't work anymore. Only the detection of the compiler shall use the newest one, all other commands shall start with oldest version first.
This PR selects the latest GCC version on the system for the tests. If only
gcc
is available the version is detected from the output ofgcc --version
.If using
qa_compiler
session the default is switched fromgcc-5
togcc-11
(the current latest version for the reference data).