Add option for decision and function threshold #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacetown
added
Type: Enhancement
cli
Spacetown
force-pushed
the
add_option_for_decision_threshold
branch
from
61bee02
to
7cec726
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 95.62% 95.61% -0.02%
==========================================
Files 41 41
Lines 4047 4079 +32
Branches 793 805 +12
==========================================
+ Hits 3870 3900 +30
Misses 100 100
- Partials 77 79 +2
☔ View full report in Codecov by Sentry. |
Spacetown
force-pushed
the
add_option_for_decision_threshold
branch
2 times, most recently
from
74c4cc4
to
8e18ac8
Compare
Spacetown
force-pushed
the
add_option_for_decision_threshold
branch
from
8e18ac8
to
e1a5841
Compare
Spacetown
force-pushed
the
add_option_for_decision_threshold
branch
from
93c4001
to
38059e8
Compare
|
Thank you for doing this @Spacetown! Any idea when the next gcovr release is planned? |
|
Nothing planned yet. I think before end of this year should be possible. |
|
Sounds good, let me know if there's anything we can do to help! |
|
@Codym48 Review open PRs. I don't like to merge without review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--fail-under-decisionand--fail-under-functionwhich will error under a given minimum coverage.The exit code for an error of the reader module is changed from 8 to 64 and for a writer from 7 to 128 to have the coverage thresholds together.
The documentation also stated that the threshold exit statuses can be ORed. This wasn't true anymore since the writer error (7) sets also the bits for the minimum line (2) and branch coverage (4). Now this behavior is fixed.
Closes #759