Improve tests on macos clang #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The local enum with fully qualified name isn't working. The test was introduced because of a bug when a case use the scope operator, therefor the enum is moved to a namespace.
Spacetown
added
Type: Enhancement
QA
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 94.30% 94.59% +0.28%
==========================================
Files 50 50
Lines 3865 3865
Branches 811 811
==========================================
+ Hits 3645 3656 +11
+ Misses 141 130 -11
Partials 79 79 ☔ View full report in Codecov by Sentry. |
Spacetown
force-pushed
the
improve_decision_tests_on_macos_clang
branch
from
e6278e8
to
a0a81d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the test exclusions and fix the errors in the testcases.