fix: Use localstorage only if switchable #1534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use localstorage if dark variation is allowed by admin and the key exists.
|
Why do you have code checking for a username in local storage? Also, any PR for this feature should address the other open issues on the day/night feature. |
YoungWilliamZ
pushed a commit
to YoungWilliamZ/hugo-academic
that referenced
this pull request
Jul 29, 2020
…t mode Fixes: - There is no easy way for a user to reset their day/night preference back to automatic (currently, they must use their web browser to clear the local storage data for the site) - When changing the theme variation is disabled by admin (by setting `day_night` to `false` in `params.toml`), the operating system's day/night preference is still applied - If the admin removes the option to change the theme variation, the preference for a user who already visited the site is still read from the localstorage and applied. For example, this could result in the user seeing a theme variation with poor contrast that was not intended to be shown as the site's theme was optimized for the other variation. Fix HugoBlox#1385 Fix HugoBlox#1526 Fix HugoBlox#1534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use localstorage if dark variation is allowed by admin and the key exists.
Purpose
If the admin removes the "dark variation", the default is still read from the localstorage and there is no easy way for an end-user to use the mode defined by the theme (As far as I know, the only way is to use the developer options of the browser and delete the key there). Additionally, reading a persistent state makes sense if you can change this state. Otherwise, I think that the default should be used.
Screenshots
Not available.
Documentation
No documentation change.