Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Behaviours in RxUtils(Test) #55

Closed
StefMa opened this issue Jan 6, 2017 · 3 comments
Closed

Behaviours in RxUtils(Test) #55

StefMa opened this issue Jan 6, 2017 · 3 comments
Labels
rx test

Comments

@StefMa
Copy link
Contributor

StefMa commented Jan 6, 2017

While I'm working on #54 I've found some strange stuff.

  1. The test testManageViewSubscription_WithDetachSingleSub_ShouldUnsubscribe inside RxTiPresenterSubscriptionHandlerTest is equal to testManageViewSubscription_WithDetachView_ShouldUnsubscribe. So I guess we can remove it?!
    Probably I've copied the test code to the rx2 module which can be removed ❌ as well

  2. testManageViewDisposable_DetachBeforeAttach_ShouldThrowAssertError in RxiTiPresenterDisposableHandlerTest (and maybe in RxTiPresenterSubscriptionHandlerTest too) will - hopefully - never happen.
    Is it currently possible to detach a view without attaching? 🤔

  3. Should we move the TiMockPresenter inside the test module? 🤔
@StefMa StefMa mentioned this issue Jan 9, 2017
Merged
@StefMa
Copy link
Contributor Author

StefMa commented Jan 9, 2017

Nr 2 is fixed inside #58

@StefMa StefMa mentioned this issue Jan 9, 2017
Merged
3 tasks
@StefMa
Copy link
Contributor Author

StefMa commented Jan 20, 2017 •
edited

Nr 3 is fixed in #54. Because we don't need it in there...

@StefMa
Copy link
Contributor Author

StefMa commented Jan 20, 2017

Nr 1 isn't critical.
So I will close this issue :) 👍

@StefMa StefMa closed this as completed Jan 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
rx test
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StefMa