Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Add clear to Rx*Handler #62

Closed
StefMa opened this issue Jan 24, 2017 · 1 comment
Closed

Add clear to Rx*Handler #62

StefMa opened this issue Jan 24, 2017 · 1 comment
Labels

Comments

@StefMa
Copy link
Contributor

StefMa commented Jan 24, 2017

In the real world it could be happen that we want to clear all the subscriptions / disposables ,which are already added to the handler via manage*, earlier than the handler does .

So it would be great if you can provide a clear method to the Rx*Handler 👍

@StefMa StefMa added the rx label Jan 24, 2017
@passsy
Copy link
Contributor

passsy commented Jan 24, 2017

Already prepared a PR for this. Then I came to the conclusion that there is not a single case when you want to clear those subscriptions earlier. Those manage* methods are for exactly one usecase, unsubscribing when a specific lifecycle callback gets called. When you want to unsubscribe all Subscriptions earlier you should manage them yourself.

When we'd add a clear() method you could accidentally unsubscribe things which aren't meant to be unsubscribed. Especially challenging in larger teams

@StefMa StefMa closed this as completed Mar 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants