Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Presenters are leaking if do FragmentManager.popBackStack() #83

Closed
ar-g opened this issue Apr 17, 2017 · 3 comments
Closed

Presenters are leaking if do FragmentManager.popBackStack() #83

ar-g opened this issue Apr 17, 2017 · 3 comments

Comments

@ar-g
Copy link

ar-g commented Apr 17, 2017

First of all thank you for a library we are using it for all our presenters and fragments, around 50.

Recently we came across very strange behavior we have an activity with a chain of 10 fragments and when user reach the last one we are doing

getSupportFragmentManager().popBackStack(null, FragmentManager.POP_BACK_STACK_INCLUSIVE)

then we create a different fragment. All these fragments are related to one scope which we keep inside activity and after the user leaves activity component is destroyed.

What we noticed that after one such scenario we are leaking 10 presenters. And if the user does it a couple of times we will have 20 leaked presenters.

Moreover, we investigated and found that we are using popBackStack very actively throughout our app, that mean we have many presenters which are leaking.

How can we fix it?

@ar-g ar-g changed the title Presenters leaking if manually clear BackStack with fragments. Presenters are leaking if do FragmentManager.popBackStack() Apr 17, 2017
@StefMa
Copy link
Contributor

StefMa commented Apr 17, 2017

Hi,

this is a duplicate of #33 and #68.
We are already working on that on #78.
Thank you for the repot. But because we know that issue and we have already some issues for that I will close it...

@StefMa StefMa closed this as completed Apr 17, 2017
@ar-g
Copy link
Author

ar-g commented Apr 17, 2017

@StefMa Do you know when the fix will be available and how can we help to make it happen faster?

@StefMa StefMa modified the milestone: 0.8.0 Apr 18, 2017
@StefMa
Copy link
Contributor

StefMa commented Apr 18, 2017

At this time we have to deadline for fixing this bug.
But sine we have the same trouble with our internal projects we are looking forward to fix that as soon as possible.

However. You can help by reviewing (and maybe collaborate) on #78!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants