Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct get_user() call #77

Closed
raprasad opened this issue Feb 1, 2021 · 4 comments
Closed

Correct get_user() call #77

raprasad opened this issue Feb 1, 2021 · 4 comments
Assignees
Labels
pkg:api api related activities prio:asap Fix as soon as possible status:confirmed Is a valid issue and will be moved forward soon. type:bug Something isn't working
Milestone

Comments

@raprasad
Copy link

raprasad commented Feb 1, 2021

Error: e.g. Builds path with /users/:me instead of /api/v1/users/:me

  • Use self.base_url_api_native instead of self.base_url
  • Line should be:
     url = f"{self.base_url_api_native}/users/:me" 
    

url = f"{self.base_url}/api/users/:me"

@skasberger skasberger self-assigned this Feb 3, 2021
@skasberger skasberger added pkg:api api related activities prio:asap Fix as soon as possible status:confirmed Is a valid issue and will be moved forward soon. type:bug Something isn't working labels Feb 3, 2021
@skasberger skasberger added this to the v0.4.0 milestone Feb 3, 2021
@ecowan
Copy link
Contributor

ecowan commented Feb 19, 2021

@skasberger
Copy link
Member

@ecowan Would you please make a PR with this against develop.

@ecowan
Copy link
Contributor

ecowan commented Feb 24, 2021

@skasberger I don't have permissions to push to the repo, but my changes are represented in our fork (the link above). Thanks!

@skasberger
Copy link
Member

done. #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:api api related activities prio:asap Fix as soon as possible status:confirmed Is a valid issue and will be moved forward soon. type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants