Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_request params get overwritten #85

Open
2 tasks done
skasberger opened this issue Feb 15, 2021 · 3 comments
Open
2 tasks done

get_request params get overwritten #85

skasberger opened this issue Feb 15, 2021 · 3 comments
Assignees
Labels
pkg:api api related activities prio:high status:confirmed Is a valid issue and will be moved forward soon. type:bug Something isn't working

Comments

@skasberger
Copy link
Member

skasberger commented Feb 15, 2021

Bug report

In pyDataverse.api, the get_request() function call does not use params, as it gets overwritten with params = {} in the first line.

1. Describe your environment

  • OS: Ubuntu, 18.03
  • pyDataverse: 0.3.0

2. Actual behaviour:

Passed params attributes get lost.

3. Expected behaviour:

Passed params should have changed the request function.

4. Steps to reproduce

Viewed the code.

5. Possible solution

@skasberger skasberger added type:bug Something isn't working pkg:api api related activities prio:high status:confirmed Is a valid issue and will be moved forward soon. labels Feb 15, 2021
@skasberger skasberger added this to the v0.4.0 milestone Feb 15, 2021
@skasberger skasberger self-assigned this Feb 15, 2021
@skasberger skasberger mentioned this issue Mar 14, 2021
35 tasks
@skasberger skasberger modified the milestones: v0.4.0, v0.3.1 Apr 1, 2021
@sergejzr
Copy link

Dear pyDataverse community,
the issue is still existing. Could you tell, what is planned the strategy in this regard?
For example, I need to ignore the certificate check on the test server through params, but this is not possible because params get overwritten.

@skasberger
Copy link
Member Author

Update: I left AUSSDA, so my funding for pyDataverse development has stopped.

I want to get some basic funding to implement the most urgent updates (PRs, Bug fixes, maintenance work). If you can support this, please reach out to me. (www.stefankasberger.at). If you have feature requests, the same.

Another option would be, that someone else helps with the development and / or maintenance. For this, also get in touch with me (or comment here).

@pdurbin
Copy link
Member

pdurbin commented Feb 14, 2024

As discussed during the 2024-02-14 meeting of the pyDataverse working group, we are closing old milestones in favor of a new project board at https://github.com/orgs/gdcc/projects/1 and removing issues (like this one) from those old milestones. Please feel free to join the working group! You can find us at https://py.gdcc.io and https://dataverse.zulipchat.com/#narrow/stream/377090-python

@pdurbin pdurbin removed this from the v0.4.0 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:api api related activities prio:high status:confirmed Is a valid issue and will be moved forward soon. type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants