Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maditr does not work without library(maditr) #15

Closed
xiaodaigh opened this issue Aug 8, 2020 · 2 comments
Closed

maditr does not work without library(maditr) #15

xiaodaigh opened this issue Aug 8, 2020 · 2 comments

Comments

@xiaodaigh
Copy link

library(dplyr)
iris %>% 
  maditr::let(lat_lon = 42) %>% 
  head

Does not work, if I do NOT first library(maditr). This is probably caused by the eval.parent,

let.data.frame <- function (data, ..., by, keyby, i) {
    eval.parent(substitute(let_if(data, i, ..., by = by, keyby = keyby)))
}

I am not an expert in NSE but what do you think about this simple fix

let.data.frame <- function (data, ..., by, keyby, i) {
    eval.parent(substitute(maditr::let_if(data, i, ..., by = by, keyby = keyby)))
}

so you don't assume people have run library(maditr).

Basically this arises from me trying to see if maditr can be integrate with disk.frame see DiskFrame/disk.frame#231

@gdemin
Copy link
Owner

gdemin commented Aug 8, 2020

Thanks, I will fix it with next release.

@gdemin
Copy link
Owner

gdemin commented May 18, 2021

Fixed in 0.8.1

@gdemin gdemin closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants