Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to support logout #9

Open
jpotts opened this issue Jul 10, 2017 · 1 comment
Open

Need to support logout #9

jpotts opened this issue Jul 10, 2017 · 1 comment

Comments

@jpotts
Copy link
Contributor

jpotts commented Jul 10, 2017

Is there a way we can easily add support for logout? In the current code, if you logout, you'll get logged back in immediately because the logout action redirects to the Share page and Google retains your credentials, so you'll just be logged right back in again.

@gdepourtales
Copy link
Owner

gdepourtales commented Jul 12, 2017

Hi @jpotts the share-oauth-sso depends on the scribe java library. I've checked if logout is supported by the API but that does not sound like it is.
In any case, logout would mean that we need to logout the user from the external Google session with the side effect of closing the session of all other related app session (GMail for example).Is this what you are looking for ?

On the other side, if the logout should be restricted to the Share session, it would be possible to add a "logout" cookie, or something similar, to the user and check the presence of this cookie in the filter process method (https://github.com/gdepourtales/share-oauth-sso/blob/master/src/main/java/ch/gadp/alfresco/OAuthSSOAuthenticationFilter.java#L393)
Setting thiscookie should be done while intercepting the Share logout request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants