Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build timestamp from BuildConfig #553

Closed
friedger opened this issue Feb 3, 2016 · 1 comment
Closed

Remove build timestamp from BuildConfig #553

friedger opened this issue Feb 3, 2016 · 1 comment

Comments

@friedger
Copy link
Contributor

friedger commented Feb 3, 2016

Use paperwork instead of BuildConfig for gitSha and timestamp

Paperwork is available at
https://github.com/zsoltk/paperwork

@tasomaniac
Copy link
Member

I've asked about this in a Slack group. I think we should fix that but I am against adding additional plugin.

Instead of new Date() using gitTimestamp improves it a lot

def gitTimestamp = 'git log -n 1 --format=%at'.execute([], rootDir).text.trim()

It will do dexing when git timestamp changes which happens when we commit. It think it is ok to do that. Dexing is done every time we change java code anyways.

@tasomaniac tasomaniac changed the title Use paperwork instead of BuildConfig for gitSha Remove build timestamp from BuildConfig Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants