Validate - removed needless login shell from chroot calls where possible (rear#1171)

[gdha]

New patch that could have a serious impact on rebuilding the initrd on a recovered Linux system
See patch rear/rear@caa3de0

@jsmeix asked to run a validation test for rear/rear#1171

Need to wait on a new rebuild of the unstable rear package - test may start on Friday 20-Jan-2017

[jsmeix]

Wow - that looks impressive!
I look forward to
https://fosdem.org/2017/schedule/event/backup_dr_automated_testing/

[gdha]

I just did a test run of the rear-automated-test.sh script with rear-2.00-15.git201701181130.el7.x86_64 and logged into the recover VM (after a successful) recover procedure - here is a part of the saved rear.log file which proofs the modification made in rear/rear#1171 did not break ReaR.

017-01-20 09:59:37 Including finalize/Fedora/i386/170_rebuild_initramfs.sh
...
*** Creating initramfs image file '/boot/initramfs-3.10.0-514.2.2.el7.x86_64.img' done ***
2017-01-20 10:00:04 Updated initramfs with new drivers for Kernel 3.10.0-514.2.2.el7.x86_64.
2017-01-20 10:00:04 Including finalize/Linux-i386/210_install_grub.sh
/sbin/grub2-probe
2017-01-20 10:00:04 Skip installing GRUB Legacy boot loader because GRUB 2 is installed (grub-probe or grub2-probe exist).
2017-01-20 10:00:04 Including finalize/Linux-i386/220_install_elilo.sh
2017-01-20 10:00:04 Including finalize/Linux-i386/220_install_grub2.sh
2017-01-20 10:00:04 Installing GRUB2 boot loader
Installing for i386-pc platform.
grub2-install: warning: cannot open directory `/usr/share/locale': No such file or directory.
Installation finished. No error reported.
2017-01-20 10:00:22 Including finalize/Linux-i386/230_run_efibootmgr.sh

However, noticed that the modifications jsmeix:remove_needless_bash_from_chroot_calls_issue862 are not yet part of it. So this is a pre-test before the scripts were modified.

[gdha]

And with rear-2.00-17.git201701201119.el7.x86_64 (which includes the chroot modifications) it is exactly the same.

2017-01-20 16:28:05 Including finalize/Fedora/i386/170_rebuild_initramfs.sh
...
*** Creating initramfs image file '/boot/initramfs-3.10.0-514.2.2.el7.x86_64.img' done ***
2017-01-20 16:28:33 Updated initrd with new drivers for kernel 3.10.0-514.2.2.el7.x86_64.
2017-01-20 16:28:33 Including finalize/Linux-i386/210_install_grub.sh
/sbin/grub2-probe
2017-01-20 16:28:33 Skip installing GRUB Legacy boot loader because GRUB 2 is installed (grub-probe or grub2-probe exist).
2017-01-20 16:28:33 Including finalize/Linux-i386/220_install_elilo.sh
2017-01-20 16:28:33 Including finalize/Linux-i386/220_install_grub2.sh
2017-01-20 16:28:33 Installing GRUB2 boot loader
Installing for i386-pc platform.