Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebirth needs the ability to open containers! #13

Open
Fallenleader opened this issue Jan 11, 2016 · 16 comments · Fixed by #14
Open

Rebirth needs the ability to open containers! #13

Fallenleader opened this issue Jan 11, 2016 · 16 comments · Fixed by #14

Comments

@Fallenleader
Copy link
Contributor

There is currently a dependency on old Ohana to open container formats not supported with Rebirth.

Unfortunately, old Ohana is so unstable, it crashes constantly (to be more specific, it simply closes without any warning or error message), which makes extracting containers inside containers impossible.

A good example is Pokemon Y a/0/2/4, which contains map objects.
These objects are stored in .bin containers, inside of the regular garc.

@gdkchan
Copy link
Owner

gdkchan commented Jan 18, 2016

Reopened this since GARC and DARC containers are not yet supported (those are the container formats used on Pokémon, other than the XX containers, such as GR, AD, PK and so on).

@gdkchan
Copy link
Owner

gdkchan commented Feb 12, 2016

I added support for some containers, please check if the ones you wanted are already supported. If you find unsupported containers please say the names here.

@Fallenleader
Copy link
Contributor Author

So far, many existing issues I had before SEEM to be solved.

It's still too early to make that judgement, as the textures are missing on all of the map objects pulled from the archive quoted in my initial comment, and I haven't had a chance to fully poke around in either Y or AS with this update.

The few I was able to piddle with in old ohana extracted down to a combination of textures and models, but these would cause further crashes and such even in rebirth.

I would love to see a better documentation of the structure of X/Y/OR/AS, but it seems I'm the main one actually actively datamining it for my project.

All that useless info aside, consider this fixed for now, and I will report any possible issues regarding containers in specific here in the event this needs to be reopened

Thanks for your hard work, as it is making my project come along nicely, and with learning C# from said project, I might can contribute directly in the future.

@Fallenleader
Copy link
Contributor Author

Edit:
Critical Flaw in the new Ohana Rebirth update:
http://snag.gy/ohV6m.jpg

Top left is old Ohana
Middle is newest Rebirth update.
Right is the files extracted using newest update, with the current file loaded in both highlighted.

It seems that the navbar on the left disappears when an image is loaded in the latest update, as well as the aforementioned issues with textures.

I am also having issues where loading BCRES files shows nothing regardless of what the file contains occasionally getting an exception error. Now it looks like workload will be fragmented across 3 versions of ohana for now.

Newest update is a blast regardless. everything else is simple and smooth.
I will innocently ask for a simple feature here related to this issue as well:
The ability to choose whether to load a file as a container or view its contents directly (to further extract contents if ohana freaks out like it is on BCRES files). This could allow one to view files that currently cannot be natively supported in it's container format (once again, temporary fix for issues like the current BCRES one)

@gdkchan
Copy link
Owner

gdkchan commented Feb 12, 2016

The sidebar isn't supposed to show up when viewing images. It only shows up when viewing models, because the purpose of the sidebar is browsing/exporting/importing the models, textures and animations. It wouldn't make sense to include it when viewing just a plain image.

About the *.bcres issue, all the bcres files I tried so far works fine (at least the ones that worked on previous versions).

@Fallenleader
Copy link
Contributor Author

The reason the lack of a sidebar is an issue is because many files contain multiple images, and there is currently no method to browse/export them all only the first image in the file. This is shown in the provided picture, where I realized the filesize wasn't matching the single image displayed, and loading it in old ohana proved my theory true (there were more pictures in the container)

A quick check to see if the container has multiple images and generate a sidebar to view them all would be a good solution here albeit more code than a permanent sidebar solution.

@gdkchan
Copy link
Owner

gdkchan commented Feb 12, 2016

well, it is a container, you would need to extract and the images from the container and open them one by one in the new version. Unfortunately I think it have some junk before the actual darc container starts on the "file_XXXXX.bin", so you can try searching for "darc" inside on the file, and dumping the contents from there to the end of the file with a hex editor. The advantage is that you keep the original names and folder structure this way.

@robotortoise
Copy link

Okay, awesome! Now it seems Rebirth can open Kid Icarus: Uprising .arc files.

...Unfortunately, Kid Icarus: Uprising is really fun in that it has .arc files within its .arc files, and then .bcmdl files inside those.

I've currently been using Every File Explorer to extract the .bcmdl files within the double-layer of .arc files, but if you could add the ability to open and/or extract archives within archives, that'd be awesome!

..Seriously, what does compressing it twice do? I doubt it actually saves space. Can't they just use folders for file structures like everyone else? Sheesh, Project Sora.....

@Fallenleader
Copy link
Contributor Author

@robotortoise this latest build does exactly what you mentioned. As i pointed out with the sidebar issue, it still needs furtheraddressing. I understand @gdkchan 's intention here in hiding the sidebar, but as I mentioned, the reason this issue was presented and has not been closed is because many games have this double archive solution, and until this is addressed, the issue has not been resolved.

On that note, old Ohana also had an issue where the double arc's it could actually open without crashing would also require extraction. This is minor and doesn't warrant immediate attention.

@gdkchan I still propose that for now the user should have the option to disable the side panel in order to address the double arc issue. as I pointed out, I had no ability to sift through and extract all the images in the arc i opened, and was still dependent on the buggy old Ohana that is no longer available to general public. If necessary I will host the old version if this will not be addressed (not meaning to sound rude here.)

@Fallenleader
Copy link
Contributor Author

@robotortoise Almost forgot. that double archive seems to be for security rather than compression. It could simply imply that there may be other resources we havent been able to figure out, or simply for padding reasons. Referr to PSP dummy files. While the PSP used a disc, and dummy files made more sense, a custom crafted garc could achieve a similar buffer effect to provide specific addressing for the game. the other possibility is that when working with teams, they might have shared the files in a garc, and later they actually compressed them. think a stored non compressed zip file in a compressed rar file.

@gdkchan
Copy link
Owner

gdkchan commented Feb 26, 2016

and was still dependent on the buggy old Ohana that is no longer available to general public. If necessary I will host the old version if this will not be addressed (not meaning to sound rude here.)

Well, it is still available... Theres that page on ProjectPokemon with the lastest build and also forks of the original repository, even through I deleted it. But if you want to host it it's alright.

@Fallenleader
Copy link
Contributor Author

Sure, will share a link once I have it in my mega.

@robotortoise
Copy link

@robotortoise this latest build does exactly what you mentioned. As i pointed out with the sidebar issue, it still needs furtheraddressing.

It doesn't work with Kid Icarus: Uprising's archives, anyways. If I double click on an archive inside an archive, it doesn't open it, like Every File Explorer does.

...Ohana Rebirth seems to be doing a lot better than Every File Explorer. EFE currently opens archives better, but it doesn't view models as well as Ohana does. I'm hoping that if Ohana opens the archives within archives correctly I can rely on it entirely, rather than use EFE.
...EFE doesn't support animations. Ohana does.

Anyways, the archive within archive thing isn't too big of a deal. I can extract them with other programs for now.

@Fallenleader
Copy link
Contributor Author

So you cannot extract the container and THEN open the container that was extracted? That doesn't make sense :P

I did say that ohana simply achieves the ability to access these archives now, I never said that it allows you to simply open it like windows explorer and multiple folders.

IDK, just TRY extracting the archive before opening it.

@robotortoise
Copy link

Oh, sorry, I misunderstood.

Yeah, you can certainly extract them and then open said extracted folders, but if I'm gonna be doing that, why not just use Every File Explorer to dump the .bcres model and texture in the first place, then import into Ohana?

That's the way I've been doing it thus far. I can continue doing it either way. :P

@Fallenleader
Copy link
Contributor Author

yea, I was having issues with EFE, so this was a life saver for me. once the other issues are resolved for containers with multiple files, this will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants