Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME 45 Support #184

Closed
realmazharhussain opened this issue Sep 24, 2023 · 5 comments
Closed

GNOME 45 Support #184

realmazharhussain opened this issue Sep 24, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@realmazharhussain
Copy link
Member

realmazharhussain commented Sep 24, 2023

Continuing the discussion from #183 (comment).

Explanation

In GNOME 45, the GNOME Shell developers have added support for a light shell theme, dividing gnome-shell.css into two parts; gnome-shell-dark.css and gnome-shell-light.css. Whereas this app works only with gnome-shell.css. It uses this name to detect if any theme in /usr/share/themes or /usr/share/gnome-shell/gnome-shell-theme.gresource is a valid shell theme or not. So, the app cannot apply settings when used on GNOME 45.

@realmazharhussain
Copy link
Member Author

@orowith2os I've applied some changes. It should work now. Try this flatpak.

@orowith2os
Copy link

Yep, that works. Thanks!

Though I have to do some cursed ostree admin unlock or rpm-ostree usroverlay shenanigans in order to get the gresource to actually apply; I'm trying to sort that out with upstream gnome-shell folks now.

@realmazharhussain
Copy link
Member Author

I'm trying to sort that out with upstream gnome-shell folks now.

They, most likely, won't help you with this.

  1. Editing gresource files can break software:

    Gresource files are not meant to be edited by the user or any external program. So, customizing the shell by modifying the gresource file is not and will never be officially supported by the shell developers.

    Unfortunately, modifying gnome-shell-theme.gresource is currently the only option if someone wants to do some basic customization (e.g. changing the background color) of GDM. So, gdm-settings has to use this method.

  2. The only way customizing GDM on image-based/immutable distros can be easy is if GDM officially supported some customization. You can open an issue about it in GDM GitLab but as we all know, GNOME doesn't like the idea of customization, specially if the idea is coming from someone who is not a core GNOME developer. I feel sad to say this but I don't think GDM will officially support customization anytime soon.

Also note that you having to run ostree commands is the result of your system being image based, and not a gnome-shell specific issue. You'll have to run those commands if you want to change literally anything in /usr.

@orowith2os
Copy link

The only way customizing GDM on image-based/immutable distros can be easy is if GDM officially supported some customization. You can open an issue about it in GDM GitLab but as we all know, GNOME doesn't like the idea of customization, specially if the idea is coming from someone who is not a core GNOME developer. I feel sad to say this but I don't think GDM will officially support customization anytime soon.

This is the path I am taking. It is not as black and white as you think - it's mostly just design discussion, and trying to figure out how one would implement it in a way that satisfies designers. This isn't other desktops, where they don't care about making things consistent and just having features galore. The fact that GNOME doesn't like customization is false; GNOME doesn't like customization that can break things, and is inconsistent.

@realmazharhussain
Copy link
Member Author

realmazharhussain commented Sep 27, 2023

The fact that GNOME is well thought out rather than full of overwhelming amount of settings is one of the things I like about GNOME. Things are just right, out of the box. And it still has personalization/customization options that really matter e.g. Dark Mode, etc.

But in my experience, whenever someone suggests any customizability for the login screen, there may be discussions, but in the end, nothing comes out of it.

If it is different this time, I'll be very glad to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants