Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest version does NOT get installed #28

Closed
cscalfani opened this issue Jun 16, 2017 · 5 comments
Closed

Newest version does NOT get installed #28

cscalfani opened this issue Jun 16, 2017 · 5 comments

Comments

@cscalfani
Copy link

I had a repo go from version 4.1.0 to 4.1.1. My elm-package.json is looking for 4.0.0 <= v < 5.0.0.

Every time I run elm-github-install, it finds the 4.1.0 version in the cache and installs that.

The only way to get it to install correctly, is to DELETE the cache files.

@takaczapka
Copy link

Even more, if I have a new version of the package (moving from 1.1.2 to 1.1.3) and update in my project's elm-package.json to be "1.1.3 <= v < 2.0.0" it will not find it unless I delete cached version from $HOME/.elm-install/github/.

@wende
Copy link

wende commented Jul 4, 2017

Same here.

BTW @gdotdesign I wanted to say this project was enormous help in making https://github.com/wende/elmchemy. You're our hero 🙌

@gdotdesign
Copy link
Owner

I'm aware of this issue, and I'm planning of fixing it this week. (I was on holiday)

It comes from the fact that git repositories are decentralized and there are no single server where we could check for new versions. Currently there is no mechanism for updating repositories so only those versions are available which existed when they repository was cloned.

I'll probably do something like Crystal does which is when checking the versions of a package we would fetch the repository (thus updating it) instead of checking the current state (which can be stale).

A workaround is to go to the repository (in the cache folder) and do a manual git fetch, which would update it and the subsequent install would work after that.

BTW @gdotdesign I wanted to say this project was enormous help in making https://github.com/wende/elmchemy. You're our hero 🙌

Thanks 😄 it means a lot 👍

@gdotdesign
Copy link
Owner

This PR should fix it #30

It comes with one downside that all installs will be slower because of all the fetches that need to take place.

@takaczapka @wende @cscalfani if any of you could test it out I would be grateful, just let me know if you need me to create a build (in case you can't install from source or from github directly).

@gdotdesign
Copy link
Owner

Released as v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants