Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of Godot 4 #20

Closed
CZakarya opened this issue May 6, 2023 · 8 comments
Closed

Update to latest version of Godot 4 #20

CZakarya opened this issue May 6, 2023 · 8 comments
Labels
help wanted Extra attention is needed invalid This doesn't seem right

Comments

@CZakarya
Copy link

CZakarya commented May 6, 2023

Changes have been made in Godot 4 so that this project doesn't work in the latest version of Godot.

@tung-nt-niteco
Copy link

Yeah, there are a couple of things to change, including this one:
#18

Then,
set_target_location -> set_target_position
get_next_location -> get_next_path_position

It worked for me after all.

@NathanLovato
Copy link
Contributor

The project is running fine for our team in Godot 4.0.2, the latest stable version. There are no instances of get_next_location() or set_target_location() in the source code. Did you guys pull the latest changes? It sounds like you might have downloaded an older copy of the source code.

@NathanLovato NathanLovato added invalid This doesn't seem right help wanted Extra attention is needed labels May 8, 2023
@akien-mga
Copy link
Contributor

I confirm that it's working fine for me in the latest main branch of this repo with Godot 4.0.2.

The only issues I found are a couple warnings of changed/not-found UID, and emission_energy_multiplier changing in one material when opening it in the editor.

@NathanLovato
Copy link
Contributor

Thanks, closing for now as it seems to be working fine around the team. I invite you to re download the code to get the latest version, and if it fails to open please let me know and we'll reopen the issue.

@tung-nt-niteco
Copy link

Noticed that I downloaded the code by clicking the button on https://www.gdquest.com/news/2022/12/godot-4-third-person-controller/, that is why I got the old code :)

@NathanLovato
Copy link
Contributor

Thanks for mentioning this, I'll update the link!

@BillyJoelsNightmareExplosion

Thanks for mentioning this, I'll update the link!

Hey just to let you know @NathanLovato, the download link on the site still points to an older version.

@Starzky
Copy link

Starzky commented Nov 12, 2023

On v4.1.3.stable.official [f06b6836a], the player drops straight through the terrain - progressively, until falling straight out of the bottom of the ground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

6 participants