Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a close button to the Practice completed window #52

Closed
YuriSizov opened this issue Dec 29, 2021 · 4 comments
Closed

Add a close button to the Practice completed window #52

YuriSizov opened this issue Dec 29, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request user experience Improvement to the interface or user interactions
Milestone

Comments

@YuriSizov
Copy link
Contributor

From backer's comments:

I've completed the first lesson Practice, and I don't like that it pushes me out of the lesson as soon as I press Play. I wanted to close the Well done! dialog and review the execution status of the program (in particular, whether the print("Welcome!") line had been printed to the Output console), but the "Got it!" button closes the environment and I need to navigate back to the lesson and re-read the full text and answer all the quizzes to access the practice environment again.

And they have a point. So I think we could just add a button to close the popup and remain in the practice, while still tracking that practice as completed. We can maybe even add another button to the bottom of the practice screen itself to go to the next practice/lesson that is unlocked after you complete it once.

@YuriSizov YuriSizov added enhancement New feature or request user experience Improvement to the interface or user interactions labels Dec 29, 2021
@YuriSizov YuriSizov added this to the 0.2 milestone Dec 29, 2021
@NathanLovato
Copy link
Contributor

Yup our tester said the same. I thought I have logged an issue for that, might have forgotten.

@dialmove
Copy link

dialmove commented Dec 29, 2021

While you're at it, could you please also add a button to the previous practice as well? I solved lesson 3 practices out of order, starting with "Make the robot upright", and I was surprised when completing it that it moved me to lesson 4 while I had still one more practice to go.

(Also, there's an off-by-one error in the top-left lesson title) ;-)

image

image

@YuriSizov
Copy link
Contributor Author

Sure, we should probably add some indication that the user has unfinished practices before moving them to the next lesson, and allow them to go back to them and finish them.

@xix-xeaon
Copy link

I think you shouldn't even be able to "move on" right away. You want the student to review the work they did (now that they got it right) Before moving on. You should only have a close button, and then a button to move on to the next part / lesson should be easy to find but also "in the corner" or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user experience Improvement to the interface or user interactions
Projects
None yet
Development

No branches or pull requests

4 participants