Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create function for canny edge detection #16

Open
apekshamanchanda opened this issue Nov 1, 2020 · 2 comments · Fixed by #28
Open

Create function for canny edge detection #16

apekshamanchanda opened this issue Nov 1, 2020 · 2 comments · Fixed by #28

Comments

@apekshamanchanda
Copy link
Contributor

apekshamanchanda commented Nov 1, 2020

Resource: https://docs.opencv.org/master/da/d22/tutorial_py_canny.html

Add the code in the effects.py file , a function called edge_detection has already been created there, edit that function to render the effect on the frame by referring to the above resource.

@amanem1
Copy link
Contributor

amanem1 commented Apr 29, 2021

hi i have sent a pr , can you check and tell, what to improve.!

@srishti-negi srishti-negi linked a pull request May 22, 2021 that will close this issue
@srishti-negi
Copy link
Collaborator

hi i have sent a pr , can you check and tell, what to improve.!

Hey!
There are a couple of issues with this pr. I have listed them below, please make the necessary changes.

  1. The function for image blurring is 'GaussianBlur' not 'gaussianBlur'.
  2. As stated in the issue, the purpose of this function was to render the effect on the frame, so instead of edges you need to modify the frame variable.
  3. There is no need to use imshow function as the purpose of the edge_detection function is to return image as a bytes object without displaying it. There is another function(out of scope of this issue) which is responsible for displaying this image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants