Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please check and tell me needed changes #6

Closed
wants to merge 2 commits into from
Closed

Please check and tell me needed changes #6

wants to merge 2 commits into from

Conversation

nilupulmanodya
Copy link
Contributor

Description

  1. Replacing Null values
  2. Remove unwanted features and rows
  3. Change categorical data types to categorical

Checklist

  • I am making a proper pull request, not spam.

  • I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests

Preprocess the dataset : Handling NULL values & Duplicate features #1

Add relevant screenshot or video (if any)

Copy link
Member

@niloysikdar niloysikdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagnik1511 please review this pr and merge if everything seems good.

@sagnik1511
Copy link
Collaborator

df = df.astype('category')
df.dtypes

Hey @nilupulmanodya , can you explain what have you done here?

@sagnik1511
Copy link
Collaborator

As the issue only asks the contributor to handle the null values and the duplicates feature/rows, the updates in the PR should be strictly on those only.

@nilupulmanodya
Copy link
Contributor Author

hey @sagnik1511 ,
I thought that's easy for data clustering. I can reverse it. How about you feel other things ? can you satisfy or need any changes ?

@sagnik1511
Copy link
Collaborator

As the numeric feature can hold a euclidian distance feature, thus needed in numeric values.

@nilupulmanodya
Copy link
Contributor Author

Sure, I will change it

@sagnik1511
Copy link
Collaborator

Looks like you're new to GitHub. No need to close the PR. If you update the branch, it will directly reflect in the PR.

@nilupulmanodya
Copy link
Contributor Author

Thank you so much. I will try in next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants