Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default installation python -m pip install gdsfactory requires kfactory #1713

Closed
sebastian-goeldi opened this issue May 30, 2023 · 2 comments · Fixed by #1714
Closed

Default installation python -m pip install gdsfactory requires kfactory #1713

sebastian-goeldi opened this issue May 30, 2023 · 2 comments · Fixed by #1714
Labels
bug Something isn't working

Comments

@sebastian-goeldi
Copy link
Collaborator

Describe the bug
The default installation now requires kfactory due to the default import of difftest. This results in a package that when installed freshly doesn't work and crashes on import.

To Reproduce
python -m pip install gdsfactory in a fresh environment

Expected behavior
The package should install in a working condition by default

Suggested fix
Either add kfactory as a dependency or make the import of difftest not default and add a warning when trying to import without having kfactory installed

@sebastian-goeldi sebastian-goeldi added the bug Something isn't working label May 30, 2023
@joamatab
Copy link
Contributor

joamatab commented May 30, 2023

Hi Sebastian,

In the difftest I added try, except
#1712

How does that sound?

@sebastian-goeldi
Copy link
Collaborator Author

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants